From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19271 invoked by alias); 9 Mar 2012 11:44:42 -0000 Received: (qmail 19261 invoked by uid 22791); 9 Mar 2012 11:44:41 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 11:44:23 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q29BiMbj002201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Mar 2012 06:44:22 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q29BiL95004234; Fri, 9 Mar 2012 06:44:21 -0500 Message-ID: <4F59ED15.1030109@redhat.com> Date: Fri, 09 Mar 2012 11:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Jonathan Larmour CC: gdb-patches@sourceware.org Subject: Re: Fwd: Re: [patch] Add support for ARMv7M devices. References: <4F598611.4020506@eCosCentric.com> In-Reply-To: <4F598611.4020506@eCosCentric.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00330.txt.bz2 On 03/09/2012 04:24 AM, Jonathan Larmour wrote: > Over a year ago, after discussion and some helpful pointers from Daniel, I > submitted this patch: > > http://sourceware.org/ml/gdb-patches/2010-11/msg00142.html > > Unfortunately it fell by the wayside. > > This issue is coming to a head for the eCos project as we are updating our > ARM toolchain (we avoid the bleeding edge). However that means we really > need GDB to preserve backward compatibility, which it presently fails to do. > > We don't want to break backward compatibility with installed GDB stubs, > and the XML solution is complicated for users, opaque, not really suitable > for Eclipse (although there may be proprietary plugins around which try to > solve this, that isn't relevant for public GDB). Most importantly the > attached patch should flexibly work everywhere, and not break anyone's > compatibility. And furthermore, it allows us a clean migration path to the > changed 'g' packet length. > > So I'm attaching an updated version of the patch for current GDB trunk. If > it helps, I do have an FSF assignment and, from prehistory, commit > permissions. I support this. I wrote essentially the same without being aware of your patch: . Wish I had seen yours before that. If there are no other comments in a week or so, I say put this in. On 03/09/2012 04:24 AM, Jonathan Larmour wrote: > } > + else > + is_m = 0; > I think this is unnecessary though. The variable is initialized to 0. -- Pedro Alves