From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25003 invoked by alias); 8 Mar 2012 11:05:07 -0000 Received: (qmail 24995 invoked by uid 22791); 8 Mar 2012 11:05:06 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_XS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 11:04:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q28B4mc6031556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Mar 2012 06:04:48 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q28B4kXL025633; Thu, 8 Mar 2012 06:04:47 -0500 Message-ID: <4F58924E.7060101@redhat.com> Date: Thu, 08 Mar 2012 11:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] s/sprint/xsnprintf/ in remote.c References: <1331185673-25417-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1331185673-25417-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00258.txt.bz2 On 03/08/2012 05:47 AM, Yao Qi wrote: > @@ -8002,7 +8009,7 @@ remote_insert_hw_breakpoint (struct gdbarch *gdbarch, > { > CORE_ADDR addr; > struct remote_state *rs; > - char *p; > + char *p, *endbuf; > > /* The length field should be set to the size of a breakpoint > instruction, even though we aren't inserting one ourselves. */ > @@ -8015,6 +8022,7 @@ remote_insert_hw_breakpoint (struct gdbarch *gdbarch, > > rs = get_remote_state (); > p = rs->buf; > + endbuf = rs->buf + get_remote_packet_size (); > > *(p++) = 'Z'; > *(p++) = '1'; > @@ -8022,10 +8030,11 @@ remote_insert_hw_breakpoint (struct gdbarch *gdbarch, > > addr = remote_address_masked (bp_tgt->placed_address); > p += hexnumstr (p, (ULONGEST) addr); > - sprintf (p, ",%x", bp_tgt->placed_size); > + xsnprintf (p, rs->buf + get_remote_packet_size () - p, ",%x", > + bp_tgt->placed_size); You seem to have endbuf handy, so `endbuf - p' would be better. > > if (remote_supports_cond_breakpoints ()) > - remote_add_target_side_condition (gdbarch, bp_tgt, p); > + remote_add_target_side_condition (gdbarch, bp_tgt, p, endbuf); > > putpkt (rs->buf); > getpkt (&rs->buf, &rs->buf_size, 0); > @@ -8060,7 +8069,8 @@ remote_remove_hw_breakpoint (struct gdbarch *gdbarch, > > addr = remote_address_masked (bp_tgt->placed_address); > p += hexnumstr (p, (ULONGEST) addr); > - sprintf (p, ",%x", bp_tgt->placed_size); > + xsnprintf (p, rs->buf + get_remote_packet_size () - p, ",%x", > + bp_tgt->placed_size); Would probably make sense for consistency with remote_insert_hw_breakpoint to do `endbuf - p' here too. Otherwise looks fine. Thanks for doing this. -- Pedro Alves