From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3933 invoked by alias); 7 Mar 2012 18:35:22 -0000 Received: (qmail 3871 invoked by uid 22791); 7 Mar 2012 18:35:21 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MISSING_HEADERS X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Mar 2012 18:35:08 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1S5Lhb-0004wW-Ci from Luis_Gustavo@mentor.com ; Wed, 07 Mar 2012 10:35:07 -0800 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 7 Mar 2012 10:34:59 -0800 Received: from [0.0.0.0] ([172.16.63.104]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 7 Mar 2012 10:35:06 -0800 Message-ID: <4F57AA57.6010106@mentor.com> Date: Wed, 07 Mar 2012 18:35:00 -0000 From: Luis Gustavo Reply-To: "Gustavo, Luis" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.27) Gecko/20120216 Lightning/1.0b2 Thunderbird/3.1.19 MIME-Version: 1.0 CC: gdb-patches@sourceware.org, Jan Kratochvil Subject: Re: [PATCH] Make AX engine fail gracefully due to unknown types References: <4F57A77E.307@mentor.com> In-Reply-To: <4F57A77E.307@mentor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00231.txt.bz2 Obviously i forgot to mention that this fixes PR 13781... :-) On 03/07/2012 03:22 PM, Luis Gustavo wrote: > Hi, > > The target-side conditionals patch exposes the AX engine to a wider > range of use cases, and it does not seem to be prepared to handle all > those right now. > > One example is handling of unsupported types, like float. The proposed > fix makes the AX engine fail gracefully when it sees unknown/unsupported > types. It does this without compromising the debugging session like an > internal error. > > This fixes the internal error seen in gdb.cp/mb-templates.exp, where we > have two locations for a single conditional breakpoint (i==1). The > problem here is that i is INT for one of the locations and FLOAT for the > other. > > With the fix, GDB handles those two locations' conditions appropriately. > > I've also reverted the KFAIL workaround for mb-templates.exp. > > Regtested in X86. > > Ok?