From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1880 invoked by alias); 6 Mar 2012 10:26:39 -0000 Received: (qmail 1872 invoked by uid 22791); 6 Mar 2012 10:26:38 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Mar 2012 10:26:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q26AQ06B005885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 6 Mar 2012 05:26:00 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q26APxMY024376; Tue, 6 Mar 2012 05:25:59 -0500 Message-ID: <4F55E636.8040501@redhat.com> Date: Tue, 06 Mar 2012 10:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Andreas Arnez CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] s390-nat.c: Fix missing prototypes References: <8762ejrlqv.fsf@vnet.ibm.com> <20120305190642.GJ2853@adacore.com> <87ipiigiup.fsf@linux.vnet.ibm.com> In-Reply-To: <87ipiigiup.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00181.txt.bz2 On 03/06/2012 09:49 AM, Andreas Arnez wrote: > Joel Brobecker writes: > >>> Tested on s390x-ibm-linux with no regressions, fixes a >>> -Wmissing-prototypes build failure. >>> >>> gdb/ >>> 2012-03-05 Andreas Arnez >>> >>> * s390-nat.c: Include "gregset.h". >> >> Thanks! Attached is what I committed for you. I dropped the comment, >> since I felt it was completely redundant. > > Thanks! Dropping the comment is OK. However, you also relocated the > include statement. This doesn't work, because "gregset.h" uses a > typedef from the system header file . The order of > inclusion matters, and any other than my original patch may not work > either. Every other linux arch I looked at included before gregset.h instead (or gdb_proc_service.h, which pulls sys/procfs.h). Even core-regset.c does: #ifdef HAVE_SYS_PROCFS_H #include #endif /* Prototypes for supply_gregset etc. */ #include "gregset.h" ... Are s390's headers different in this regard? I think we should consider putting #ifdef HAVE_SYS_PROCFS_H #include #endif in gregset.h itself. -- Pedro Alves