From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26250 invoked by alias); 6 Mar 2012 07:54:57 -0000 Received: (qmail 26238 invoked by uid 22791); 6 Mar 2012 07:54:56 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Mar 2012 07:54:37 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q267sahk015260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 6 Mar 2012 02:54:36 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q267sZI5030031; Tue, 6 Mar 2012 02:54:36 -0500 Message-ID: <4F55C2BB.7090205@redhat.com> Date: Tue, 06 Mar 2012 07:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [patch 1/2] libunwind/ia64: Rename libunwind-frame.[ch] References: <20120304215728.GA2763@host2.jankratochvil.net> In-Reply-To: <20120304215728.GA2763@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00172.txt.bz2 On 03/04/2012 09:57 PM, Jan Kratochvil wrote: > Hi, > > this is just a rename, it breaks the build, but it makes the changes > reviewable in [patch 2/2]. It would be checked-in as a single commit. BTW, there's a different way to split this so that you don't mix the rename with other changes to the same files, and so that git log sees through pure file renames without trouble. That is, you rename the header in one patch, and rename the c file in the other patch. For example: In patch #1 rename libunwind-frame.h -> ia64-tdep-libunwind-frame.h but otherwise don't touch ia64-tdep-libunwind-frame.h. Also do all other adjustments to the other files so that the build doesn't break (except for the build bits that need adjustment to compile ia64-tdep-libunwind-frame.o instead). In patch #2 rename libunwind-frame.c -> ia64-tdep-libunwind-frame.c but otherwise don't touch ia64-tdep-libunwind-frame.c. Do the build bits adjustment to build ia64-tdep-libunwind-frame.o instead in this patch. Or the other way around, (there's more than one way to split this). The point is not to touch the same file you're renaming in the same commit you're doing the rename in. -- Pedro Alves