From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] OO tracepoint_action
Date: Fri, 02 Mar 2012 01:06:00 -0000 [thread overview]
Message-ID: <4F501CF1.8000507@codesourcery.com> (raw)
In-Reply-To: <1330650011-31899-3-git-send-email-yao@codesourcery.com>
On 03/02/2012 09:00 AM, Yao Qi wrote:
> This is the major part of this patch series, which replace several
> switch/case blocks in code with function vectors. It is easier to add
> new operation to tracepoint_action in the future.
This patch is a mechanical refactor change, except in
do_action_at_tracepoint. In GDBserver, we can install
tracepoint_action_ops when creating tracepoint_action objects, however,
in IPA, all tracepoint_actions objects are written from GDBserver. So
when writing tracepoint_actions to IPA, we firstly write field `ops' to
NULL, and check it in do_action_at_tracepoint. If `ops' field is NULL,
install corresponding tracepoint_action_ops instances. The other
approach is to expose the symbols of tracepoint_action_ops instances to
GDBserver, so GDBserver can write it to `ops' field. This approach
exposed too much details of IPA (symbols of tracepoint_action_ops
variables), so I don't use it.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-03-02 1:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 1:00 [patch 0/2] " Yao Qi
2012-03-02 1:00 ` [PATCH 2/2] " Yao Qi
2012-03-02 1:06 ` Yao Qi [this message]
2012-03-02 11:50 ` Pedro Alves
2012-03-02 13:36 ` Yao Qi
2012-03-02 13:50 ` Pedro Alves
2012-03-02 1:00 ` [PATCH 1/2] New field stop_pc in tracepoint_hit_ctx Yao Qi
2012-03-02 10:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F501CF1.8000507@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox