From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15377 invoked by alias); 1 Mar 2012 21:25:59 -0000 Received: (qmail 15361 invoked by uid 22791); 1 Mar 2012 21:25:58 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 21:25:35 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21LPZIP028513 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 16:25:35 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q21LPXNY017301 for ; Thu, 1 Mar 2012 16:25:34 -0500 Message-ID: <4F4FE94D.90200@redhat.com> Date: Thu, 01 Mar 2012 21:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: C version of jit-reader.h:plugin_is_GPL_compatible broken References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> <20120229161951.23918.68388.stgit@hit-nxdomain.opendns.com> <4F4E5C55.1040909@redhat.com> In-Reply-To: <4F4E5C55.1040909@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00049.txt.bz2 On 02/29/2012 05:11 PM, Pedro Alves wrote: > On 02/29/2012 04:19 PM, Pedro Alves wrote: >> #define GDB_DECLARE_GPL_COMPATIBLE_READER >> + extern int plugin_is_GPL_compatible (void); \ >> extern int plugin_is_GPL_compatible (void) \ > > Hmm, I just noticed this is broken, even before my patch. > There's a `\' missing at the end of GDB_DECLARE_GPL_COMPATIBLE_READER, > like in: > > #define GDB_DECLARE_GPL_COMPATIBLE_READER \ > extern int plugin_is_GPL_compatible (void) \ > > This is the !__cplusplus variant. The C++ variant is okay. > I'm checking this in. 2012-03-01 Pedro Alves * jit-reader.in [!__cplusplus] (GDB_DECLARE_GPL_COMPATIBLE_READER): Add missing backslash. --- diff --git a/gdb/jit-reader.in b/gdb/jit-reader.in index 42c28b5..3ad521a 100644 --- a/gdb/jit-reader.in +++ b/gdb/jit-reader.in @@ -45,7 +45,7 @@ extern "C" { #else -#define GDB_DECLARE_GPL_COMPATIBLE_READER +#define GDB_DECLARE_GPL_COMPATIBLE_READER \ extern int plugin_is_GPL_compatible (void); \ extern int plugin_is_GPL_compatible (void) \ { \