From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15101 invoked by alias); 1 Mar 2012 20:26:18 -0000 Received: (qmail 15080 invoked by uid 22791); 1 Mar 2012 20:26:12 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 20:25:58 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21KPwrt016590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 15:25:58 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q21KPtw0031425 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Thu, 1 Mar 2012 15:25:57 -0500 Message-ID: <4F4FDB53.20306@redhat.com> Date: Thu, 01 Mar 2012 20:26:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Allow user-defined as a category for python gdb macros (resend) References: <03E840D17E263A48A5766AD576E0423A03D72B653F@exch-mbx-111.vmware.com> <4F3A5820.3080905@redhat.com> <03E840D17E263A48A5766AD576E0423A03D72B6547@exch-mbx-111.vmware.com> <03E840D17E263A48A5766AD576E0423A03DAB7AED1@exch-mbx-111.vmware.com> <03E840D17E263A48A5766AD576E0423A03D72B6554@exch-mbx-111.vmware.com> <03E840D17E263A48A5766AD576E0423A03D72B6555@exch-mbx-111.vmware.com> <03E840D17E263A48A5766AD576E0423A03DAB7B84A@exch-mbx-111.vmware.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------070003090001000002020703" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00042.txt.bz2 This is a multi-part message in MIME format. --------------070003090001000002020703 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 973 On 03/01/2012 11:31 AM, Doug Evans wrote: > Hi. > Committed. I've committed the attached patch, which updates the doc string modified by this patch: >>> @@ -1912,7 +1913,7 @@ Two arguments (separated by a comma) are taken as >>> a range of memory to dump,\n\ >>> Run the ``make'' program using the rest of the line as arguments.")); >>> set_cmd_completer (c, filename_completer); >>> add_cmd ("user", no_class, show_user, _("\ >>> -Show definitions of user defined commands.\n\ >>> +Show definitions of non-python user defined commands.\n\ >>> Argument is the name of the user defined command.\n\ >>> With no argument, show definitions of all user defined commands."), >>> &showlist); >>> add_com ("apropos", class_support, apropos_command, This regresses a test in help.exp. Keith ChangeLog 2012-03-01 Keith Seitz * gdb.base/help.exp (help show user): Update expected result for new doc string changes (add "non-python"). --------------070003090001000002020703 Content-Type: text/x-patch; name="help.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="help.exp.patch" Content-length: 1214 Index: testsuite/gdb.base/help.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/help.exp,v retrieving revision 1.55 diff -u -p -r1.55 help.exp --- testsuite/gdb.base/help.exp 24 Jan 2012 15:13:30 -0000 1.55 +++ testsuite/gdb.base/help.exp 1 Mar 2012 20:23:41 -0000 @@ -574,7 +574,7 @@ gdb_test "help show radix" "Show the def # test help show symbol-reloading gdb_test "help show symbol-reloading" "Show dynamic symbol table reloading multiple times in one run\." "help show symbol-reloading" # test help show user -gdb_test "help show user" "Show definitions of user defined commands\.\[\r\n\]+Argument is the name of the user defined command\.\[\r\n\]+With no argument, show definitions of all user defined commands\." "help show user" +gdb_test "help show user" "Show definitions of non-python user defined commands\.\[\r\n\]+Argument is the name of the user defined command\.\[\r\n\]+With no argument, show definitions of all user defined commands\." "help show user" # test help show values gdb_test "help show values" "Elements of value history around item number IDX \\(or last ten\\)\." "help show values" # test help show verbose --------------070003090001000002020703--