From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5516 invoked by alias); 1 Mar 2012 14:52:56 -0000 Received: (qmail 5508 invoked by uid 22791); 1 Mar 2012 14:52:55 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_VT,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 14:52:43 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21EqgNG016679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 09:52:43 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q21EqfEZ020066; Thu, 1 Mar 2012 09:52:42 -0500 Message-ID: <4F4F8D39.60507@redhat.com> Date: Thu, 01 Mar 2012 14:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [4/5] implement "info vtable" References: <87mx82prmd.fsf@fleche.redhat.com> In-Reply-To: <87mx82prmd.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00017.txt.bz2 On 02/28/2012 09:36 PM, Tom Tromey wrote: > This one needs a doc review, and of course commentary on the naming and > output. > > This adds a new command, "info vtable". This command can be used to > inspect the virtual tables of an object. My only gripe is that we end up with the vtable vs vtbl inconsistency (set print vtbl). So (gdb) apropos vtbl and (gdb) apropos vtable will show different commands... May be a good idea if the docs are augmented a bit to give an example, and lightly explain the output. IIUC, "info vtable POINTER" works. The tests only sees to try "info vtable OBJ". Worth adding a test that tries through a pointer? -- Pedro Alves