From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6079 invoked by alias); 1 Mar 2012 11:47:44 -0000 Received: (qmail 6068 invoked by uid 22791); 1 Mar 2012 11:47:43 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 11:47:29 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21BlThB020787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 06:47:29 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q21BlSSP003726; Thu, 1 Mar 2012 06:47:28 -0500 Message-ID: <4F4F61D0.60801@redhat.com> Date: Thu, 01 Mar 2012 11:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: Tom Tromey , jan.kratochvil@redhat.com Subject: Re: [PATCH 1/2] gdb.threads/attach-into-signal.exp: cleanup References: <20120217193546.10029.74207.stgit@hit-nxdomain.opendns.com> <20120217193648.10029.26589.stgit@hit-nxdomain.opendns.com> <87pqdd9pjs.fsf@fleche.redhat.com> <4F3EBFEE.5020202@redhat.com> In-Reply-To: <4F3EBFEE.5020202@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00013.txt.bz2 On 02/17/2012 09:00 PM, Pedro Alves wrote: > On 02/17/2012 08:24 PM, Tom Tromey wrote: >>>>>>> "Pedro" == Pedro Alves writes: >> >> Pedro> - build different executable files for the non-threaded and threaded >> Pedro> cases. This was my motivation. I wanted to test the non-threaded >> Pedro> case manually, but the threaded variant always clobbered the >> Pedro> non-threaded executable. >> >> I think this ought to be a general rule. We need exceptions to it for >> some executable-changed cases, but I think in general different tests >> should build different executables, because this makes it easier to do >> additional checking by hand. > > Yeah, agreed. Perhaps we should write it down somewhere. > I guess the wiki's test cookbook could be a good place. Now mentioned over at . -- Pedro Alves