From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22262 invoked by alias); 29 Feb 2012 17:12:04 -0000 Received: (qmail 22253 invoked by uid 22791); 29 Feb 2012 17:12:03 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 17:11:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1THBobW032554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Feb 2012 12:11:50 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1THBnkP000454 for ; Wed, 29 Feb 2012 12:11:50 -0500 Message-ID: <4F4E5C55.1040909@redhat.com> Date: Wed, 29 Feb 2012 17:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH 09/14] -Wmissing-prototypes: jit-reader.in (plugin_is_GPL_compatible). References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> <20120229161951.23918.68388.stgit@hit-nxdomain.opendns.com> In-Reply-To: <20120229161951.23918.68388.stgit@hit-nxdomain.opendns.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00718.txt.bz2 On 02/29/2012 04:19 PM, Pedro Alves wrote: > #define GDB_DECLARE_GPL_COMPATIBLE_READER > + extern int plugin_is_GPL_compatible (void); \ > extern int plugin_is_GPL_compatible (void) \ Hmm, I just noticed this is broken, even before my patch. There's a `\' missing at the end of GDB_DECLARE_GPL_COMPATIBLE_READER, like in: #define GDB_DECLARE_GPL_COMPATIBLE_READER \ extern int plugin_is_GPL_compatible (void) \ This is the !__cplusplus variant. The C++ variant is okay. -- Pedro Alves