From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88292-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30202 invoked by alias); 28 Feb 2012 17:13:38 -0000
Received: (qmail 30193 invoked by uid 22791); 28 Feb 2012 17:13:37 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Feb 2012 17:13:24 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1SHCwEe018019	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 28 Feb 2012 12:12:58 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1SHCu9l023400;	Tue, 28 Feb 2012 12:12:57 -0500
Message-ID: <4F4D0B18.5040402@redhat.com>
Date: Tue, 28 Feb 2012 17:27:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1
MIME-Version: 1.0
To: "Maciej W. Rozycki" <macro@codesourcery.com>
CC: gdb-patches@sourceware.org, Doug Evans <dje@google.com>,        Joel Brobecker <brobecker@adacore.com>
Subject: Re: Ping: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
References: <alpine.DEB.1.10.1111101340460.4191@tp.orcam.me.uk> <CADPb22Qe6G76gDRkVtXhzOhR0w+3VsC9=-eHt-aM=1w8+V7qPg@mail.gmail.com> <alpine.DEB.1.10.1111111907260.4191@tp.orcam.me.uk> <alpine.DEB.1.10.1112081529330.5354@tp.orcam.me.uk> <alpine.DEB.1.10.1202272056010.4811@tp.orcam.me.uk>
In-Reply-To: <alpine.DEB.1.10.1202272056010.4811@tp.orcam.me.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00664.txt.bz2

On 02/27/2012 09:04 PM, Maciej W. Rozycki wrote:
> Hi,
> 
>  Where are we with this proposal of mine:
> 
> http://sourceware.org/ml/gdb-patches/2011-11/msg00316.html
> 
> ?  Here's another update to add changes corresponding to recent 
> adjustments to break.exp and to accomodate the year roll-over:

I read the thread from the start, and I diffed the new proposed test against break.exp,
and I think we should go ahead and put this in.  Only a couple remarks below.

> +#   Copyright 2012 Free Software Foundation, Inc.

I think dropping the original copyright years was a mistake.

> +if { [prepare_for_testing hbreak2.exp "break" {break.c break1.c} {debug nowarnings}] } {

s/"break"/"hbreak2", so that running this test doesn't overwrite break.exp's binary.
More instances of this.

-- 
Pedro Alves