From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix disp-step-syscall.exp on some i386 targets
Date: Tue, 28 Feb 2012 10:14:00 -0000 [thread overview]
Message-ID: <4F4CA669.7040209@codesourcery.com> (raw)
In-Reply-To: <20120228084050.GA1296@host2.jankratochvil.net>
On 02/28/2012 04:40 PM, Jan Kratochvil wrote:
> I do not mind much but it makes some assumption if PC did not change it was by
> a syscall without checking it really was a syscall at all. There could be for
> example some "jmp *%ebx" with %ebx == _start and it would be falsely relocated
> by your patch back to its code location, ignoring its intended jump. The
> patch of mine would not relocate it as %orig_eax remained 0.
>
> But any code messing with the entry point address may confuse this
> autodetection anyway so these countercases are more hypothetical.
>
> What do you think about the %orig_eax verification?
It looks reasonable to me then, better than my approach. It would be
better if we can add some comments to explain this fix is a hack and why
we have to do in this way.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-02-28 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 20:49 Jan Kratochvil
2012-02-28 8:17 ` Yao Qi
2012-02-28 9:24 ` Jan Kratochvil
2012-02-28 10:14 ` Yao Qi [this message]
2012-02-28 13:55 ` Jan Kratochvil
2012-02-28 14:57 ` Yao Qi
2012-02-29 16:14 ` [commit] " Jan Kratochvil
2012-02-28 15:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4CA669.7040209@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox