From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] PR server/9684: gdbserver, attach to stopped processes
Date: Mon, 27 Feb 2012 17:26:00 -0000 [thread overview]
Message-ID: <4F4BAFAA.3070607@redhat.com> (raw)
In-Reply-To: <20120224230012.GL2692@adacore.com>
On 02/24/2012 11:00 PM, Joel Brobecker wrote:
>> I'm a bit ambivalent on this. I found out that this isn't actually
>> necessary on recent kernels (I haven't looked for the exact version or
>> commit that made it so) -- waitpid no longer hangs. OTOH, we still
>> need it on systems with not so recent kernels where support is still
>> well active, so I figure this may be useful to many upstream as well.
>
> FWIW, I tend to agree. If it is possibly useful to others, and it's
> not intrusive, it is all good reasons for the patch to go in. I took
> a look just to have an idea of what it's about, and it seems like
> a reasonably uninvasive patch...
Thanks for weighing in.
> As always, I always marvel at the beautiful and informative comments
> that explain why we have to do all these horrible things :-).
I can't take credit for this; I'm just copying Dan's comment
from linux-nat.c.
--
Pedro Alves
next prev parent reply other threads:[~2012-02-27 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 23:00 Pedro Alves
2012-02-24 23:22 ` Joel Brobecker
2012-02-27 17:26 ` Pedro Alves [this message]
2012-02-25 5:58 ` Jan Kratochvil
2012-02-27 16:24 ` Pedro Alves
2012-02-25 6:24 ` Yao Qi
2012-02-27 16:31 ` move pid_is_stopped to common/ Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BAFAA.3070607@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox