From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23748 invoked by alias); 27 Feb 2012 16:23:18 -0000 Received: (qmail 23733 invoked by uid 22791); 27 Feb 2012 16:23:15 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Feb 2012 16:22:50 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1RGMnAv001797 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Feb 2012 11:22:49 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1RGMmHV021144; Mon, 27 Feb 2012 11:22:49 -0500 Message-ID: <4F4BADD8.5070509@redhat.com> Date: Mon, 27 Feb 2012 16:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [PATCH] PR server/9684: gdbserver, attach to stopped processes References: <20120224222127.14659.51317.stgit@hit-nxdomain.opendns.com> <20120225035743.GA17325@host2.jankratochvil.net> In-Reply-To: <20120225035743.GA17325@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00629.txt.bz2 On 02/25/2012 03:57 AM, Jan Kratochvil wrote: > On Fri, 24 Feb 2012 23:21:27 +0100, Pedro Alves wrote: >> Tested with the extended-remote board on x86_64 Fedora 16 (3.2, >> doesn't need patch), and x86_64 RHEL 5.8 (2.6.18, needs patch). > > Looks OK to me, thanks. > >> + /* The process is definitely stopped. It is in a job control >> + stop, unless the kernel predates the TASK_STOPPED / > + >> + First make sure there is a pending SIGSTOP. Since we are >> + already attached, the process can not transition from stopped > + >> + /* Finally, resume the stopped process. This will deliver the >> + SIGSTOP (or a higher priority signal, just like normal > > There are spaces instead of tabs. Indeed, thanks. Fixed that and applied. -- Pedro Alves