Re: [patch] Assert when 'break' with no arguments

[Aleksandar Ristovski <aristovski@qnx.com>]

On 12-02-24 10:41 AM, Pedro Alves wrote:
> On 02/14/2012 08:44 PM, Aleksandar Ristovski wrote:
>> --- gdb/stack.c	7 Feb 2012 04:48:22 -0000	1.247
>> +++ gdb/stack.c	14 Feb 2012 20:43:08 -0000
>> @@ -909,6 +909,11 @@ set_last_displayed_sal (int valid, struc
>>     last_displayed_addr = addr;
>>     last_displayed_symtab = symtab;
>>     last_displayed_line = line;
>> +  if (valid&&  pspace == NULL)
>> +    {
>> +      warning (_("Trying to set NULL pspace."));
>
> Is there a case when this isn't a gdb bug?  IOW, any reason this isn't a gdb_assert?
> This seems like a rather cryptic warning to show to a user.

I believe it would be a bug.

However, gdb_assert is rather destructive. The warning is to bring it to 
our attention, but continue so users can actually do debugging if this 
happens.

My thinking was: if sal is invalidated the rest of the code should 
continue functioning thus providing more value to the user (albeit maybe 
somewhat confused user) than killing the session.

Anyway that was my rationale.


---
Aleksandar