From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23039 invoked by alias); 24 Feb 2012 13:01:06 -0000 Received: (qmail 23031 invoked by uid 22791); 24 Feb 2012 13:01:05 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 13:00:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OD0mMP001936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 Feb 2012 08:00:48 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1OD0kh4009108; Fri, 24 Feb 2012 08:00:47 -0500 Message-ID: <4F4789FE.7080004@redhat.com> Date: Fri, 24 Feb 2012 13:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: "Gustavo, Luis" CC: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [rfc target-side break conditions 5/5 v2] GDBServer-side changes References: <4F230A29.3060404@mentor.com> <4F31A249.9000800@earthlink.net> <4F3301C1.9070400@mentor.com> <4F33BCE9.8080900@redhat.com> <4F450705.2010407@mentor.com> <4F466A38.8080109@redhat.com> <4F477FC3.6060605@mentor.com> <4F4784C5.7020402@redhat.com> <4F478803.30505@mentor.com> In-Reply-To: <4F478803.30505@mentor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00548.txt.bz2 On 02/24/2012 12:52 PM, Luis Gustavo wrote: > > 2012-02-24 Luis Machado > > gdbserver/ > * server.c (handle_query): Advertise support for target-side > breakpoint condition evaluation. > (process_point_options): New function. > (process_serial_event): When inserting a breakpoint, check for > a target-side condition that should be evaluated. > > * mem-break.c: Include regcache.h and ax.h. > (point_cond_list_t): New data structure. > (breakpoint) : New field. > (find_gdb_breakpoint_at): Make non-static. > (delete_gdb_breakpoint_at): Clear any target-side > conditions. > (clear_gdb_breakpoint_conditions): New function. > (add_condition_to_breakpoint): Likewise. > (add_breakpoint_condition): Likewise. > (gdb_condition_true_at_breakpoint): Likewise. > (gdb_breakpoint_here): Return result directly instead > of going through a local variable. > > * mem-break.h (find_gdb_breakpoint_at): New prototype. > (clear_gdb_breakpoint_conditions): Likewise. > (add_breakpoint_condition): Likewise. > (gdb_condition_true_at_breakpoint): Likewise. > > * linux-low.c (linux_wait_1): Evaluate target-side breakpoint condition. > (need_step_over_p): Take target-side breakpoint condition into > consideration. Okay. -- Pedro Alves