From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22005 invoked by alias); 24 Feb 2012 12:59:13 -0000 Received: (qmail 21994 invoked by uid 22791); 24 Feb 2012 12:59:12 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 12:58:57 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OCws28015216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 Feb 2012 07:58:54 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1OCwqmL015847; Fri, 24 Feb 2012 07:58:53 -0500 Message-ID: <4F47898C.3000509@redhat.com> Date: Fri, 24 Feb 2012 13:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: "Gustavo, Luis" CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [rfc target-side break conditions 3/5 v2] GDB-side changes References: <4F230A13.9060400@mentor.com> <4F3107C2.2060400@mentor.com> <4F32CDF2.8090906@redhat.com> <4F32E167.6050600@mentor.com> <4F33C27E.2090304@redhat.com> <4F4508BA.8060901@mentor.com> <4F467655.6040603@redhat.com> <4F478045.9060405@mentor.com> In-Reply-To: <4F478045.9060405@mentor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00547.txt.bz2 On 02/24/2012 12:19 PM, Luis Gustavo wrote: > @@ -14459,8 +15148,8 @@ The \"Type\" column indicates one of:\n\ > \twatchpoint - watchpoint\n\ > The \"Disp\" column contains one of \"keep\", \"del\", or \"dis\" to indicate\n\ > the disposition of the breakpoint after it gets hit. \"dis\" means that the\n\ > -breakpoint will be disabled. The \"Address\" and \"What\" columns indicate the\n\ > -address and file/line number respectively.\n\ > +breakpoint will be disabled. The \"Address\" and \"What\" columns indicate\n\ > +the address and file/line number respectively.\n\ > \n\ > Convenience variable \"$_\" and default examine address for \"x\"\n\ > are set to the address of the last breakpoint listed unless the command\n\ > @@ -14476,8 +15165,8 @@ The \"Type\" column indicates one of:\n\ > \twatchpoint - watchpoint\n\ > The \"Disp\" column contains one of \"keep\", \"del\", or \"dis\" to indicate\n\ > the disposition of the breakpoint after it gets hit. \"dis\" means that the\n\ > -breakpoint will be disabled. The \"Address\" and \"What\" columns indicate the\n\ > -address and file/line number respectively.\n\ > +breakpoint will be disabled. The \"Address\" and \"What\" columns indicate\n\ > +the address and file/line number respectively.\n\ > \n\ > Convenience variable \"$_\" and default examine address for \"x\"\n\ > are set to the address of the last breakpoint listed unless the command\n\ > @@ -14495,8 +15184,8 @@ The \"Type\" column indicates one of:\n\ > \twatchpoint - watchpoint\n\ > The \"Disp\" column contains one of \"keep\", \"del\", or \"dis\" to indicate\n\ > the disposition of the breakpoint after it gets hit. \"dis\" means that the\n\ > -breakpoint will be disabled. The \"Address\" and \"What\" columns indicate the\n\ > -address and file/line number respectively.\n\ > +breakpoint will be disabled. The \"Address\" and \"What\" columns indicate\n\ > +the address and file/line number respectively.\n\ > \n\ > Convenience variable \"$_\" and default examine address for \"x\"\n\ > are set to the address of the last breakpoint listed unless the command\n\ > @@ -14515,8 +15204,8 @@ The \"Type\" column indicates one of:\n\ > \tfinish - internal breakpoint used by the \"finish\" command\n\ > The \"Disp\" column contains one of \"keep\", \"del\", or \"dis\" to indicate\n\ > the disposition of the breakpoint after it gets hit. \"dis\" means that the\n\ > -breakpoint will be disabled. The \"Address\" and \"What\" columns indicate the\n\ > -address and file/line number respectively.\n\ > +breakpoint will be disabled. The \"Address\" and \"What\" columns indicate\n\ > +the address and file/line number respectively.\n\ > \n\ All these look like unintended changes now. Otherwise looks very good. Thanks. -- Pedro Alves