Re: [rfc target-side break conditions 5/5 v2] GDBServer-side changes

Pedro Alves
2012-02-24T12:38:49Z

On 02/24/2012 12:17 PM, Luis Gustavo wrote:
> + If we failed to evaluate the expression, TRUE is returned. This
> + forces GDB to reevaluate the conditions. */
> + for (cl = bp->cond_list;
> + cl && !value && !err; cl = cl->next)
> + {
> + /* Evaluate the condition. */
> + err = gdb_eval_agent_expr (regcache, NULL, cl->cond, &value);
> + }
> +
> + return (value != 0);
> +}

Shouldn't there be a

if (err)
return 1;

somewhere?

IOW, what is guaranteeing that value is != 0 when gdb_eval_agent_expr returns error?

Otherwise looks good.

--
Pedro Alves