From: Pedro Alves <palves@redhat.com>
To: "Gustavo, Luis" <luis_gustavo@mentor.com>
Cc: Stan Shebs <stanshebs@earthlink.net>, gdb-patches@sourceware.org
Subject: Re: [rfc target-side break conditions 5/5 v2] GDBServer-side changes
Date: Fri, 24 Feb 2012 12:52:00 -0000 [thread overview]
Message-ID: <4F4784C5.7020402@redhat.com> (raw)
In-Reply-To: <4F477FC3.6060605@mentor.com>
On 02/24/2012 12:17 PM, Luis Gustavo wrote:
> + If we failed to evaluate the expression, TRUE is returned. This
> + forces GDB to reevaluate the conditions. */
> + for (cl = bp->cond_list;
> + cl && !value && !err; cl = cl->next)
> + {
> + /* Evaluate the condition. */
> + err = gdb_eval_agent_expr (regcache, NULL, cl->cond, &value);
> + }
> +
> + return (value != 0);
> +}
Shouldn't there be a
if (err)
return 1;
somewhere?
IOW, what is guaranteeing that value is != 0 when gdb_eval_agent_expr returns error?
Otherwise looks good.
--
Pedro Alves
next prev parent reply other threads:[~2012-02-24 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 20:34 Luis Gustavo
2012-02-07 22:14 ` Stan Shebs
2012-02-08 23:14 ` Luis Gustavo
2012-02-09 12:33 ` Pedro Alves
2012-02-22 15:25 ` Luis Gustavo
2012-02-23 17:25 ` Pedro Alves
2012-02-24 12:19 ` Luis Gustavo
2012-02-24 12:52 ` Pedro Alves [this message]
2012-02-24 12:59 ` Luis Gustavo
2012-02-24 13:01 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4784C5.7020402@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis_gustavo@mentor.com \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox