From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88161-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22509 invoked by alias); 24 Feb 2012 07:57:23 -0000
Received: (qmail 22493 invoked by uid 22791); 24 Feb 2012 07:57:21 -0000
X-SWARE-Spam-Status: No, hits=-1.4 required=5.0	tests=AWL,BAYES_00,TW_BJ
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 07:57:07 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1S0q1a-0000QD-0s from Yao_Qi@mentor.com ; Thu, 23 Feb 2012 23:57:06 -0800
Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Thu, 23 Feb 2012 23:57:02 -0800
Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 23 Feb 2012 23:57:04 -0800
Message-ID: <4F474296.7010201@codesourcery.com>
Date: Fri, 24 Feb 2012 08:34:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20120130 Thunderbird/10.0
MIME-Version: 1.0
To: Pedro Alves <palves@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 8/9] impl of use_agent and can_use_agent in linux-nat.
References: <1329447300-18841-1-git-send-email-yao@codesourcery.com> <1329447300-18841-9-git-send-email-yao@codesourcery.com> <4F46B981.5070108@redhat.com>
In-Reply-To: <4F46B981.5070108@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00533.txt.bz2

On 02/24/2012 06:11 AM, Pedro Alves wrote:
>> > @@ -925,7 +926,10 @@ solib_add (char *pattern, int from_tty,
>> >  	}
>> >  
>> >      if (loaded_any_symbols)
>> > -      breakpoint_re_set ();
>> > +      {
>> > +	breakpoint_re_set ();
>> > +	agent_look_up_symbols ();
> The right place to do this is in a new new_objfile observer.
> 

Why not a new solib_loaded observer, which is more accurate, IMO.

-- 
Yao (齐尧)