Re: [PATCH 4/9] agent doc

Eli Zaretskii
2012-02-22T20:41:11Z

> Date: Wed, 22 Feb 2012 20:25:06 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
>
> Hmm, it still seems incorrect in the exact same way.
>
> > -When GDB is debugging a remote target, the GDB @dfn{agent} code running
> > +Although called @dfn{agent expression}, because they originally
> > +referred to the in-process agent (@pxref{In-Process Agent}), these
>
> Still false. Looks unchanged compared to the previous version?
>
> > +When @value{GDBN} is debugging, the @value{GDBN} agent code running
> > on the target computes the values of the expressions itself. To avoid
> > -having a full symbolic expression evaluator on the agent, GDB translates
> > -expressions in the source language into a simpler bytecode language, and
> > -then sends the bytecode to the agent; the agent then executes the
> > -bytecode, and records the values for GDB to retrieve later.
> > +having a full symbolic expression evaluator on the agent or remote stub,
>
> This is still confused on agent vs in-process agent. The remote stub is
> an agent as well; it does things for gdb (e.g., GDBserver supports tracepoints).
> Note the several references to "agent" on this whole paragraph. I suggest
> really just leave this paragraph as it was.
>
> > +@value{GDBN} translates expressions in the source language into a simpler
> > +bytecode language, and then sends the bytecode to the agent; the agent
> > +then executes the bytecode, and records the values for @value{GDBN} to
> > +retrieve later.
>
> We lost the intro about tracepoints, so this mention of recording values
> for gdb to retrieve later is now awkward.

Pedro, how about if you write whatever you think we should say there,
in whatever shape it is easy for you, and I will then polish it if
necessary? (The "polish" suggestion is to avoid wasting too much of
your time on stylistic issues.)