From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9377 invoked by alias); 23 Feb 2012 21:05:07 -0000 Received: (qmail 9367 invoked by uid 22791); 23 Feb 2012 21:05:07 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Feb 2012 21:04:51 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1NL4miT013719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 Feb 2012 16:04:48 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1NL4lYC028489; Thu, 23 Feb 2012 16:04:47 -0500 Message-ID: <4F46A9EE.2000808@redhat.com> Date: Thu, 23 Feb 2012 21:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/9] move agent related code from gdbserver to common/agent.c References: <1329447300-18841-1-git-send-email-yao@codesourcery.com> <1329447300-18841-2-git-send-email-yao@codesourcery.com> <4F46A923.1090005@redhat.com> In-Reply-To: <4F46A923.1090005@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00518.txt.bz2 On 02/23/2012 09:01 PM, Pedro Alves wrote: argh, a sign that I probably shouldn't be reviewing at this late hour. I meant, > Something fishy with the indentation here. Make entries and indented Make sure entries are indented with one tab. > breakpoint (e.g., a breakpoint at write/read, or a catch system), or a catch syscall. -- Pedro Alves