From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12359 invoked by alias); 23 Feb 2012 17:51:24 -0000 Received: (qmail 12332 invoked by uid 22791); 23 Feb 2012 17:51:21 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Feb 2012 17:51:03 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1S0coo-0003QB-Gl from Luis_Gustavo@mentor.com ; Thu, 23 Feb 2012 09:51:02 -0800 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 23 Feb 2012 09:51:01 -0800 Received: from [0.0.0.0] ([172.16.63.104]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 23 Feb 2012 09:51:01 -0800 Message-ID: <4F467C9B.2080404@mentor.com> Date: Thu, 23 Feb 2012 17:55:00 -0000 From: Luis Gustavo Reply-To: "Gustavo, Luis" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: Pedro Alves CC: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [rfc target-side break conditions 1/5 v2] Documentation bits References: <4F2309FF.9050708@mentor.com> <83zkd8xmky.fsf@gnu.org> <4F450AA9.3020501@mentor.com> <4F467963.4040701@redhat.com> In-Reply-To: <4F467963.4040701@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00511.txt.bz2 On 02/23/2012 03:37 PM, Pedro Alves wrote: > On 02/22/2012 03:32 PM, Luis Gustavo wrote: > >> +* New options >> + >> +set breakpoint condition-evaluation >> +show breakpoint condition-evaluation >> + Controls whether breakpoint conditions are evaluated by GDB ("gdb") or by >> + GDBserver ("target"). >> + This option can improve debugger efficiency depending on the speed of the >> + target. >> + >> +* New remote packets >> + >> + The z0/z1 breakpoint insertion packets have been extended to carry >> + a list of conditional expressions over to GDBserver depending on the > > suggest s/GDBserver/the remote stub/ > > (making clear the packet isn't only useful with GDB's own server.) > I'd rather make this "the target", as this stuff may be carried over to the IPA running on the target's side. It also is aligned with the "target" mode naming. >> +If a breakpoint is conditional, there are two evaluation modes: ``gdb'' and >> +``target''. If mode is ``gdb'', breakpoint condition evaluation is done by >> +@value{GDBN} on the host's side. If it is ``target'', then the condition >> +is evaluated by the target. The @code{info break} command shows >> +the condition on the line following the affected breakpoint, together with >> +its condition evaluation mode in between parentheses. > > I'm probably confused by now, but I thought that the modes are now "host" and > "target". Other than that, no comment. I think the docs changes look great. > They are host and target now. This is what happens when the naming changes a couple times. :-) Fixed.