Re: RFA: New port: ia64-hp-openvms (2/3)

Tristan Gingold
2012-02-13T08:45:49Z

On Feb 12, 2012, at 10:39 AM, Mark Kettenis wrote:

>> From: Tristan Gingold <gingold@adacore.com>
>> Date: Fri, 10 Feb 2012 14:22:56 +0100
>>
>> The easiest way to get the unwind entry is to ask to the OpenVMS
>> kernel, as this always work. Might not be optimal for the user
>> application, but it is bullet-proof.
>>
>> Tristan.
>>
>> 2012-02-10 Tristan Gingold <gingold@adacore.com>
>>
>> * target.h (target_object): Add TARGET_OBJECT_OPENVMS_UIB.
>> * remote.c (PACKET_qXfer_uib): New enum value.
>> (remote_protocol_features): Add entry for PACKET_qXfer_uib.
>> (remote_xfer_partial): Handle TARGET_OBJECT_OPENVMS_UIB.
>
> Don't know much about (Open)VMS, but...
>
>> diff --git a/gdb/remote.c b/gdb/remote.c
>> index 3187ac0..7787864 100644
>> --- a/gdb/remote.c
>> +++ b/gdb/remote.c
>> @@ -8417,6 +8420,12 @@ remote_xfer_partial (struct target_ops *ops, enum target_object object,
>> case TARGET_OBJECT_FDPIC:
>> return remote_read_qxfer (ops, "fdpic", annex, readbuf, offset, len,
>> &remote_protocol_packets[PACKET_qXfer_fdpic]);
>> +
>> + case TARGET_OBJECT_OPENVMS_UIB:
>> + return remote_read_qxfer
>> + (ops, "uib", annex, readbuf, offset, len,
>> + &remote_protocol_packets[PACKET_qXfer_uib]);
>> +
>
> Formatting here is different from the TARGET_OBJECT_FDPIC bit just before.

Right, but it follows the one of TARGET_OBJECT_TRACEFRAME_INFO :-)
Will fix.

Tristan.