Re: [rfc target-side break conditions ] Testcase

Pedro Alves
2012-02-14T14:29:57Z

I'm not seeing how this test is intended to catch as is. Any other
GDB output will PASS as long as it ends in the prompt, which usually
does.

On 02/08/2012 11:16 PM, Luis Gustavo wrote:
> +# If target-side condition evaluation is not supported, this warning will be
> +# displayed.
> +set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n"
> +
> +gdb_test_multiple $test_target $test_target {
> + -re $warning {

This should match $gdb_prompt as well. Otherwise, you confuse the following tests.

> + unsupported $test_target
> + return -1
> + }
> +
> + -re "\r\n$gdb_prompt " {

Did you intend to make sure that _only_ the prompt was output, like
gdb_tests_no_output? If so, then you need to make that:

-re "^$test_target\r\n$gdb_prompt $" {

> + pass $test_target
> + }
> +}

--
Pedro Alves