Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h

Jan Kratochvil
2012-02-14T14:36:25Z

On Tue, 14 Feb 2012 13:13:53 +0100, Pedro Alves wrote:
> On 02/14/2012 07:27 AM, Jan Kratochvil wrote:
> > the patch does not apply to HEAD,
>
> Huh. It did for me.

I expect your MUA corrupted whitespaces:

#-- head$
#++ patch$
#@ -6,7 +6,7 @@ esac],[$
enable_libunwind=yes;$
fi$
])$
- $
+$
if test x"$enable_libunwind" = xyes; then$
AC_CHECK_HEADERS(libunwind.h libunwind-ia64.h)$
AC_DEFINE(HAVE_LIBUNWIND, 1, [Define if libunwind library is being used.])$

> > If the non-ia64 libunwind support is therefore really removed the dead code in
> > libunwind-frame.c should be also removed with some comments making it ia64
> > specific.
>
> What dead code?

At least `libunwind_frame_unwind' is dead - it has no references in the
codebase - which confused me.

Also when you change GDB design by this patch - from arch-independent
libunwind-frame.c to ia64-limited libunwind-frame.c - one should best rename
libunwind-frame.[ch] to libunwind-ia64-frame.[ch]. Otherwise at least write
some comments there this file is used only for ia64 targets now.

> The code is not really ia64 specific.

Yes, because it was designed to be possibly used in the future with arbirary
arch.

Regards,
Jan