Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h

Pedro Alves
2012-02-10T18:59:13Z

On 02/10/2012 06:43 PM, Jan Kratochvil wrote:
> On Fri, 10 Feb 2012 19:33:34 +0100, Pedro Alves wrote:
>> What about --enable-targets=all, or --target=x86_64-foo --enable-target=ia64-xxx ?
>
> I forgot to add a note that this solution is far from perfect. But I find
> such general libunwind support outside of the scope of this patch. This patch
> just tries to:
> * fix libunwind support for ia64 natively
> * fix libunwind support for ia64 cross
> * keep libunwind for non-ia64 support in non-regressing somehow working state

I wasn't pointing at anything related to making libunwind of general
use. The issue is that you're using $target to detect when to include
libunwind-ia64.h. That's broken for the --enable-targets=all,
or --target=x86_64-foo --enable-target=ia64-xxx cases, when --target is _not_
ia64-*. That is, it looks to me that the fix should be to make sure we include
libunwind-ia64.h in ia64 relative code, no matter the $target. Or maybe I missed
something?

>
> Personally I do not think it makes sense to use libunwind with gdb for
> non-ia64. GDB can unwind on its own there.

That's not what I was talking about.

--
Pedro Alves