Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h

Jan Kratochvil
2012-02-21T05:25:07Z

On Mon, 20 Feb 2012 23:00:53 +0100, Pedro Alves wrote:
> Fix GDB's broken inclusion of "libunwind.h".
> As I've explained before, including "libunwind.h" in GDB is _always_ wrong
> for GDB.

Not in the native mode. For example core files support on some platforms is
also supported only natively now.

> I don't imagine how any multi-arch work we do to libunwind would make it
> possible to include "libunwind.h".

For native build of GDB - which is IMO 99% of its builds - with a oneliner
patch of installing the unwinder it should work fully multi-arch.

After your patch it will be slightly more complicated patch to make the
libunwind support multi-arch (in native mode).

> But in any case, this is much more than the real need we have now. And I
> don't see why we can't fix the include problem, and do multi-arching as
> follow up work as necessary.
+
> I don't see how different the result will be from today's state,

Currently the code has some attempt to be multi-arch, despite not yet there.
Let's say it is in 50% of the multi-arch libunwind supports.

After this limitation to ia64 it will be at 30% of the multi-arch libunwind
support.

We have already spent more time talking about it than to either making it
ia64-exclusive making the support 0% or to making the support fully multi-arch
being 100% where nobody needs to talk about it anymore.

The code in GDB which no longer makes sense but still is neither removed nor
fixed makes it difficult for any contributions, coding, reviewing, anything,
besides a few people who know what it should mean one day in the future.
This is the reason why #if 0 code can be removed as [obv].

Thanks,
Jan