From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31722 invoked by alias); 13 Feb 2012 18:58:06 -0000 Received: (qmail 31711 invoked by uid 22791); 13 Feb 2012 18:58:05 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Feb 2012 18:57:44 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1DIvT58019332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 13 Feb 2012 13:57:29 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1DIvRRc003901; Mon, 13 Feb 2012 13:57:28 -0500 Message-ID: <4F395D17.5070303@redhat.com> Date: Mon, 13 Feb 2012 18:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Tristan Gingold , "gdb-patches@sourceware.org ml" Subject: Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h References: <5D1CD28F-F628-475C-B6D8-5FCBF5290C63@adacore.com> <20120210182705.GA32459@host2.jankratochvil.net> <4F3562FE.7050106@redhat.com> <20120211140919.GA24043@host2.jankratochvil.net> In-Reply-To: <20120211140919.GA24043@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00241.txt.bz2 On 02/11/2012 02:09 PM, Jan Kratochvil wrote: > -#include "libunwind.h" > +#if defined HAVE_LIBUNWIND_IA64_H > +# include "libunwind-ia64.h" > +#elif defined HAVE_LIBUNWIND_H > +# include "libunwind.h" > +#else > +# error "HAVE_LIBUNWIND && !HAVE_LIBUNWIND_IA64_H && !HAVE_LIBUNWIND_H" > +#endif > Looks okay. I don't understand why we ever include "libunwind.h" though. libunwind is only ever used by ia64 currently. If some other target wanting to use libunwind shows up, then we'll need to include libunwind-fooarch.h instead to interact with the libunwind for that arch, and somehow make libunwind-frame.h|c support more than one libunwind instance. IOW, "libunwind.h" will always be conceptually wrong for gdb. Was it needed on some older version of libunwind, perhaps? -- Pedro Alves