From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16039 invoked by alias); 10 Feb 2012 18:59:13 -0000 Received: (qmail 16031 invoked by uid 22791); 10 Feb 2012 18:59:12 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Feb 2012 18:58:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1AIwd3p018908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Feb 2012 13:58:39 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1AIwcZU017052; Fri, 10 Feb 2012 13:58:38 -0500 Message-ID: <4F3568DE.4000906@redhat.com> Date: Fri, 10 Feb 2012 18:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Tristan Gingold , "gdb-patches@sourceware.org ml" Subject: Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h References: <5D1CD28F-F628-475C-B6D8-5FCBF5290C63@adacore.com> <20120210182705.GA32459@host2.jankratochvil.net> <4F3562FE.7050106@redhat.com> <20120210184352.GA1380@host2.jankratochvil.net> In-Reply-To: <20120210184352.GA1380@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00215.txt.bz2 On 02/10/2012 06:43 PM, Jan Kratochvil wrote: > On Fri, 10 Feb 2012 19:33:34 +0100, Pedro Alves wrote: >> What about --enable-targets=all, or --target=x86_64-foo --enable-target=ia64-xxx ? > > I forgot to add a note that this solution is far from perfect. But I find > such general libunwind support outside of the scope of this patch. This patch > just tries to: > * fix libunwind support for ia64 natively > * fix libunwind support for ia64 cross > * keep libunwind for non-ia64 support in non-regressing somehow working state I wasn't pointing at anything related to making libunwind of general use. The issue is that you're using $target to detect when to include libunwind-ia64.h. That's broken for the --enable-targets=all, or --target=x86_64-foo --enable-target=ia64-xxx cases, when --target is _not_ ia64-*. That is, it looks to me that the fix should be to make sure we include libunwind-ia64.h in ia64 relative code, no matter the $target. Or maybe I missed something? > > Personally I do not think it makes sense to use libunwind with gdb for > non-ia64. GDB can unwind on its own there. That's not what I was talking about. -- Pedro Alves