From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17377 invoked by alias); 10 Feb 2012 14:29:48 -0000 Received: (qmail 17363 invoked by uid 22791); 10 Feb 2012 14:29:47 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Feb 2012 14:29:34 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1RvrTi-0002YO-1h from Yao_Qi@mentor.com ; Fri, 10 Feb 2012 06:29:34 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 10 Feb 2012 06:29:33 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Fri, 10 Feb 2012 06:29:32 -0800 Message-ID: <4F3529C3.8030806@codesourcery.com> Date: Fri, 10 Feb 2012 14:29:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111220 Thunderbird/9.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [patch 7/8] Agent capability for static tracepoint References: <4F1D55D7.7030506@codesourcery.com> <4F1D6994.1080902@codesourcery.com> <4F3428D4.5060202@redhat.com> In-Reply-To: <4F3428D4.5060202@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00195.txt.bz2 On 02/10/2012 04:13 AM, Pedro Alves wrote: > On 01/23/2012 02:07 PM, Yao Qi wrote: >> > Current libinproctrace.so agent is able to do operations on static >> > tracepoint, which can be treated as one capability. This patch is to >> > teach gdbserver to check agent's capability when performing operations >> > related to static tracepoint. >> > > Hmm, not sure. Why aren't these being hooked at the same places > where we already check/call maybe_write_ipa_ust_not_loaded and > in_process_agent_loaded_ust? > maybe_write_ipa_ust_not_loaded and in_process_agent_loaded_ust returns agent is loaded or not. Considering GDB may/will support multiple different agents, which have different capability, so "agent is loaded" doesn't mean "agent has a certain capability". Is it reasonable? I'd like replace global variable `ust_loaded' with capability mechanism in agent. -- Yao (齐尧)