From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9529 invoked by alias); 9 Feb 2012 20:19:16 -0000 Received: (qmail 9473 invoked by uid 22791); 9 Feb 2012 20:18:59 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Feb 2012 20:18:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q19KIfep023234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Feb 2012 15:18:41 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q19KIeEX025366; Thu, 9 Feb 2012 15:18:41 -0500 Message-ID: <4F342A20.40303@redhat.com> Date: Thu, 09 Feb 2012 20:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [patch 3/8] Command `set agent on|off' References: <4F1D55D7.7030506@codesourcery.com> <4F1D659F.40608@codesourcery.com> In-Reply-To: <4F1D659F.40608@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00164.txt.bz2 On 01/23/2012 01:50 PM, Yao Qi wrote: > We want to leave users to decide whether they want to use agent or not, > so we add a new command `set agent on|off' in this patch. > Looks fine to me, modulo the consideration for what happens on error, pointed in the other patch. -- Pedro Alves