From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2521 invoked by alias); 9 Feb 2012 16:10:43 -0000 Received: (qmail 2500 invoked by uid 22791); 9 Feb 2012 16:10:39 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Feb 2012 16:10:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q19GANPU026011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Feb 2012 11:10:23 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q19GALFs012541; Thu, 9 Feb 2012 11:10:22 -0500 Message-ID: <4F33EFED.60502@redhat.com> Date: Thu, 09 Feb 2012 16:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Valery Khromov CC: gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [PATCH v2] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64 References: <201112201931.pBKJV4bh021140@glazunov.sibelius.xs4all.nl> <1324411833-38717-1-git-send-email-valery.khromov@gmail.com> In-Reply-To: <1324411833-38717-1-git-send-email-valery.khromov@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00147.txt.bz2 On 12/20/2011 08:10 PM, Valery Khromov wrote: > This patch provides hardware breakpoint/watchpoint support for > FreeBSD/AMD64. Most of the code is borrowed from the i386 implementation. Thanks. It looks good to me. I've applied the patch now. > Also removed not necessary DBREG_DRX macro definition. > 2011-12-20 Valery Khromov > > * i386bsd-nat.c: [HAVE_PT_GETDBREGS] (DBREG_DRX): Delete. But without this bit though. Mark only mentioned that the macro always exists on amd64, not i386: > That bit can go. FreeBSD/amd64 has always had the DBREG_DRX macro, at > least ever since support for debug registers was added. The code does mention that some versions may need it: /* Not all versions of FreeBSD/i386 that support the debug registers have this macro. */ #ifndef DBREG_DRX #define DBREG_DRX(d, x) ((&d->dr0)[x]) #endif So if this can also be removed, let's do that separately. -- Pedro Alves