From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22149 invoked by alias); 8 Feb 2012 23:05:19 -0000 Received: (qmail 22141 invoked by uid 22791); 8 Feb 2012 23:05:18 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Feb 2012 23:05:04 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1RvGZU-0002k9-9p from Luis_Gustavo@mentor.com ; Wed, 08 Feb 2012 15:05:04 -0800 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 8 Feb 2012 15:05:04 -0800 Received: from [0.0.0.0] ([172.16.63.104]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 8 Feb 2012 15:05:03 -0800 Message-ID: <4F32FF9C.60000@mentor.com> Date: Wed, 08 Feb 2012 23:05:00 -0000 From: Luis Gustavo Reply-To: "Gustavo, Luis" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: Stan Shebs CC: gdb-patches@sourceware.org Subject: Re: [rfc target-side break conditions 0/5 v2] General info References: <4F2309F1.1020703@mentor.com> <4F319875.6080800@earthlink.net> In-Reply-To: <4F319875.6080800@earthlink.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00118.txt.bz2 On 02/07/2012 07:32 PM, Stan Shebs wrote: > On 1/27/12 12:32 PM, Luis Gustavo wrote: >> Hi, >> >> This is an updated series of patches to implement target-side >> breakpoint condition evaluation. > > Overall this is looking pretty good, I just have a few nitpicks of my > own - fix those and it all should be fine to go in. > >> >> The current testsuite seems to be a good exercise for this feature >> when ran in gdbserver mode. I can provide additional tests if required. > > I would like to see at least one test of the preference setting that > runs in native mode and comes back with "not supported". I think this is > something that people will imagine is possible for native debugging, and > maybe someday it will be, but in the meantime we want to be sure that > the native config clearly reports that the setting is not going to have > any effect. I'll attach the testcase to a new mail... Luis