From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [rfc target-side break conditions 1/5 v2] Documentation bits
Date: Tue, 07 Feb 2012 21:42:00 -0000 [thread overview]
Message-ID: <4F319A9B.70902@earthlink.net> (raw)
In-Reply-To: <4F2309FF.9050708@mentor.com>
On 1/27/12 12:33 PM, Luis Gustavo wrote:
> This is the second iteration of the documentation bits.
>
> I've switched to using explicit markers for the breakpoint parameters
> in the Z packet. Conditions will be passed via the "conditions"
> marker, like the following:
>
> Z0,addr,kind,length,conditions=<cond1>;<cond2>;...;<condn>
>
I reviewed the prior discussion on protocol, and it wasn't clear to me
why we couldn't use the same semicolon/colon syntax as is used for
tracepoint packets, data packets, etc. It would look like this:
Z0,addr,kind,length[;conditions:<cond1>,<cond2>,...]
Also, in the patch:
-@itemx Z0,@var{addr},@var{kind}
+@itemx Z0,@var{addr},@var{kind},@r{[}conditions=@var{cond-expr0};@var{cond-expr1};@dots{};@var{cond-exprn}@r{]}
@cindex @samp{z0} packet
@cindex @samp{Z0} packet
Insert (@samp{Z0}) or remove (@samp{z0}) a memory breakpoint at address
@@ -34208,6 +34272,11 @@ A memory breakpoint is implemented by re
the breakpoint in bytes that should be inserted. E.g., the @sc{arm}
and @sc{mips} can insert either a 2 or 4 byte breakpoint. Some
architectures have additional meanings for @var{kind};
+@var{cond-exprn} is an optional list of conditional expressions in bytecode
+form that should be evaluated on the target's side. These are the
+conditions that should be taken into consideration when deciding if
+the breakpoint trigger should be reported back to @var{GDBN}.
You and I know that the cond-expr syntax is something like "X<hex
digits>", but we should actually say that. (And are we doing a bytecode
count, or looking for an end-of-bytecodes char?)
Stan
next prev parent reply other threads:[~2012-02-07 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 20:33 Luis Gustavo
2012-01-28 9:07 ` Eli Zaretskii
2012-02-22 16:19 ` Luis Gustavo
2012-02-23 17:46 ` Pedro Alves
2012-02-23 17:55 ` Luis Gustavo
2012-02-23 18:24 ` Pedro Alves
2012-02-24 12:38 ` Luis Gustavo
2012-02-07 21:42 ` Stan Shebs [this message]
2012-02-08 23:07 ` Luis Gustavo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F319A9B.70902@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox