From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31899 invoked by alias); 7 Feb 2012 21:32:52 -0000 Received: (qmail 31891 invoked by uid 22791); 7 Feb 2012 21:32:50 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-mealy.atl.sa.earthlink.net (HELO elasmtp-mealy.atl.sa.earthlink.net) (209.86.89.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Feb 2012 21:32:38 +0000 Received: from [70.170.59.51] (helo=macbook2.local) by elasmtp-mealy.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1RuseU-0000GS-5E for gdb-patches@sourceware.org; Tue, 07 Feb 2012 16:32:38 -0500 Message-ID: <4F319875.6080800@earthlink.net> Date: Tue, 07 Feb 2012 21:32:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [rfc target-side break conditions 0/5 v2] General info References: <4F2309F1.1020703@mentor.com> In-Reply-To: <4F2309F1.1020703@mentor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9406c337aebc14415f35589740b8906af2c350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00088.txt.bz2 On 1/27/12 12:32 PM, Luis Gustavo wrote: > Hi, > > This is an updated series of patches to implement target-side > breakpoint condition evaluation. Overall this is looking pretty good, I just have a few nitpicks of my own - fix those and it all should be fine to go in. > > The current testsuite seems to be a good exercise for this feature > when ran in gdbserver mode. I can provide additional tests if required. I would like to see at least one test of the preference setting that runs in native mode and comes back with "not supported". I think this is something that people will imagine is possible for native debugging, and maybe someday it will be, but in the meantime we want to be sure that the native config clearly reports that the setting is not going to have any effect. Stan