From: Pedro Alves <palves@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix %eflags register index on Solaris/amd64
Date: Tue, 07 Feb 2012 19:36:00 -0000 [thread overview]
Message-ID: <4F317D18.8090304@redhat.com> (raw)
In-Reply-To: <yddty32seuj.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On 02/07/2012 06:00 PM, Rainer Orth wrote:
> When I looked at %eflags in gdb, I found that
> it was always shown as 0/empty, which makes no sense. Digging around in
> gdb, I found the culprit: in both amd64-sol2-tdep.c
> (amd64_sol2_gregset_reg_offset) and i386-sol2-nat.c
> (amd64_sol2_gregset64_reg_offs, amd64_sol2_gregset32_reg_offs) the
> offset for %eflags was wrong: <sys/regset.h> has
>
> #define EFL 16
>
> for the 32-bit case, but
>
> #define REG_RFL 19
>
> for 64-bit, while 16 in 64-bit is
>
> #define REG_ERR 16
...
> The following patch fixes this and fixes all but one of the
> gcc.dg/simulate-thread tests. I still have to investigate that last
> one.
>
> Ok for mainline?
Looks obvious to me. Ok.
You may want to double check the other registers if you haven't yet.
--
Pedro Alves
next prev parent reply other threads:[~2012-02-07 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 18:01 Rainer Orth
2012-02-07 19:36 ` Pedro Alves [this message]
2012-02-08 14:40 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F317D18.8090304@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox