On 02/06/2012 06:26 PM, Tom Tromey wrote:
> Second, I was wondering if you have any plans to extend agent
> expressions to provide more coverage for DWARF expressions.  It would be
> somewhat interesting, I think, to get some idea of how often GCC
> generates untranslatable expressions for real code.  (Like, looking at
> all the DWARF expressions in the distro... or at least some big
> libraries.)

Nothing clearly planned for now, but it should be the natural course to 
expand it in order to handle more interesting expressions.

>
> Luis>  +static const char *condition_evaluation_enums[] = {
>
> After Jan's patch I think you will need another const in there.

Fixed.

> Luis>  +/* Translate a condition evaluation mode MODE into either "gdb"
> Luis>  +   or "target.  This is used mostly to translate from "auto" to the
>
> Missing quote after "target".

Fixed as well.

> Luis>  +  /* Signals that the condition has changed since the last time
> Luis>  +     we updated the global location list.  This means the condition
> Luis>  +     needs to be sent to the target again.  This is used together
> Luis>  +     with target-side breakpoint conditions.
> Luis>  +
> Luis>  +     This field has 3 special values:
> Luis>  +
> Luis>  +     0: It means there has been no condition changes.
> Luis>  +
> Luis>  +     1: It means this location had its condition modified.
> Luis>  +
> Luis>  +     2: It means we already marked all the locations that are duplicates
> Luis>  +     of this location and thus we don't need to call
> Luis>  +     force_breakpoint_reinsertion (...) for this location.  */
> Luis>  +
> Luis>  +  char condition_changed;
>
> How about an enum instead of numerical constants?

That's better. I'm using an enum now and i've updated the other usages 
of condition_changed.

Thanks for the input!

Luis