From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6947 invoked by alias); 1 Feb 2012 16:12:12 -0000 Received: (qmail 6931 invoked by uid 22791); 1 Feb 2012 16:12:09 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Feb 2012 16:11:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q11GBh8N030489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Feb 2012 11:11:43 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q11GBgQ5021519; Wed, 1 Feb 2012 11:11:43 -0500 Message-ID: <4F29643E.1000907@redhat.com> Date: Wed, 01 Feb 2012 16:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: RFA: fix PR python/13351 References: <4F2916BE.6020105@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00017.txt.bz2 On 02/01/2012 04:04 PM, Tom Tromey wrote: > I don't understand why get_selected_frame is the preferred API. To me > it seems clearly worse: passing in an error message is ugly, and it > isn't really possible to distinguish "no frames" from "an exception was > thrown for some other reason". Neither of these problems would affect > get_selected_frame_if_set. > > Perhaps I can do the detection by checking has_stack_frames? Is that safe? Yes. Though you could just call get_selected_block instead (which does the has_stack_frames check). TRY_CATCH (except, RETURN_MASK_ALL) { - selected_frame = get_selected_frame (_("No frame selected.")); - block = get_frame_block (selected_frame, NULL); + block = get_selected_block (NULL); } GDB_PY_HANDLE_EXCEPTION (except); -- Pedro Alves