From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27970 invoked by alias); 1 Feb 2012 10:41:24 -0000 Received: (qmail 27962 invoked by uid 22791); 1 Feb 2012 10:41:23 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Feb 2012 10:41:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q11Af3JW022564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Feb 2012 05:41:03 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q11Af2E0006825; Wed, 1 Feb 2012 05:41:03 -0500 Message-ID: <4F2916BE.6020105@redhat.com> Date: Wed, 01 Feb 2012 10:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: RFA: fix PR python/13351 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00003.txt.bz2 On 01/31/2012 09:59 PM, Tom Tromey wrote: > --- a/gdb/python/py-symbol.c > +++ b/gdb/python/py-symbol.c > @@ -292,8 +292,9 @@ gdbpy_lookup_symbol (PyObject *self, PyObject *args, PyObject *kw) > > TRY_CATCH (except, RETURN_MASK_ALL) > { > - selected_frame = get_selected_frame (_("No frame selected.")); > - block = get_frame_block (selected_frame, NULL); > + selected_frame = get_selected_frame_if_set (); > + if (selected_frame) > + block = get_frame_block (selected_frame, NULL); > } I'm getting a bit nervous about get_selected_frame_if_set usages getting spread around. (It feels a bit like we're going back in time, to a time before the always-a-frame work.) The selected frame may not be set, while we still may have a current frame, so get_selected_frame would lazily select it, and so the lookup would still start on a frame block. If you don't want an error, you can pass NULL to get_selected_frame. -- Pedro Alves