From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA/commit] Rename la_get_symbol_name_match_p into la_get_symbol_name_cmp
Date: Mon, 30 Jan 2012 11:36:00 -0000 [thread overview]
Message-ID: <4F267E1A.7000409@redhat.com> (raw)
In-Reply-To: <20120130071346.GC31383@adacore.com>
On 01/30/2012 07:13 AM, Joel Brobecker wrote:
> Thanks for spotting the missing changes...
>
>> On Mon, 30 Jan 2012 07:55:22 +0100, Joel Brobecker wrote:
>>> unless there are better naming suggestions?
>>
>> Maybe "la_get_symbol_name_no_match"? As you note yourself:
>
> It's an interesting suggestion, but it introduces double-negatives,
> and I'd rather not do that.
Did you consider keeping the name, but reverse the return logic to
be what one would expect instead (return true/false for match)?
--
Pedro Alves
next prev parent reply other threads:[~2012-01-30 11:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 6:57 Joel Brobecker
2012-01-30 7:14 ` Jan Kratochvil
2012-01-30 8:50 ` Joel Brobecker
2012-01-30 11:36 ` Pedro Alves [this message]
2012-01-30 11:53 ` Joel Brobecker
2012-01-30 13:58 ` Pedro Alves
2012-02-03 8:15 ` FYI: " Joel Brobecker
2012-02-08 19:55 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F267E1A.7000409@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox