Re: [PATCH] PowerPC 32 with Secure PLT

Michael Eager
2012-01-18T17:13:57Z

On 01/18/2012 08:49 AM, Joel Brobecker wrote:
>>>> This is an area where I am not sure, but I think it would be better
>>>> to use read_memory_typed_address. I think the address type that you
>>>> want is: builtin_type (gdbarch)->builtin_func_ptr.
>>
>> I think I'd rather leave the size explicit, rather than making
>> it indirect (and unclear). This routine is only for PowerPC 32 and
>> the size of the value is always four bytes.
>
> That would be fine with me. You should be able to get rid of the cast,
> though. No?

Yep, and the cast above on the call to get_frame_register_unsigned().