From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32738 invoked by alias); 23 Jan 2012 16:31:18 -0000 Received: (qmail 32724 invoked by uid 22791); 23 Jan 2012 16:31:17 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jan 2012 16:31:04 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0NGV4Cm021784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Jan 2012 11:31:04 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0NGV2AF016034; Mon, 23 Jan 2012 11:31:03 -0500 Message-ID: <4F1D8B46.4030604@redhat.com> Date: Mon, 23 Jan 2012 16:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [patch] find_and_open_script: Fix failed fdopen References: <20120123160309.GA25174@host2.jankratochvil.net> <4F1D862D.1060608@redhat.com> <20120123161751.GA25494@host2.jankratochvil.net> In-Reply-To: <20120123161751.GA25494@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00779.txt.bz2 On 01/23/2012 04:17 PM, Jan Kratochvil wrote: > On Mon, 23 Jan 2012 17:09:17 +0100, Pedro Alves wrote: >> This do_cleanups doesn't look right. From the patch context, there's >> already do_cleanups(old_cleanups) call a bit above. > Oops, thanks. Also missing close there. Thanks. Looks correct to me now. -- Pedro Alves