Re: Call target_close after unpushing, not before (was: Re: [patch] Fix remote.c crash on gdbserver close (+fix py-finish-breakpoint.exp for gdbserver))

Jan Kratochvil
2012-01-19T16:24:19Z

On Thu, 19 Jan 2012 17:02:31 +0100, Pedro Alves wrote:
> Any comments on this?

I am fine with it with the comment update.

Thanks,
Jan

gdb/
2012-01-19 Jan Kratochvil <jan.kratochvil@redhat.com>

* target.h (target_close): Update comment on the target's unpush state.

--- a/gdb/target.h
+++ b/gdb/target.h
@@ -820,10 +820,10 @@ extern struct target_ops current_target;
longer going to be calling. QUITTING indicates that GDB is exiting
and should not get hung on an error (otherwise it is important to
perform clean termination, even if it takes a while). This routine
- is automatically always called when popping the target off the
- target stack (to_beneath is undefined). Closing file descriptors
- and freeing all memory allocated memory are typical things it
- should do. */
+ is automatically always called after popping the target off the
+ target stack - the target's own methods are no longer available
+ through the target vector. Closing file descriptors and freeing all
+ memory allocated memory are typical things it should do. */

void target_close (struct target_ops *targ, int quitting);