From: Pedro Alves <palves@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc v2][0/6] Remote /proc file access
Date: Tue, 17 Jan 2012 19:46:00 -0000 [thread overview]
Message-ID: <4F15CF0A.2030909@redhat.com> (raw)
In-Reply-To: <OFA95837EE.BE4764B3-ONC1257988.006BAC35@de.ibm.com>
On 01/17/2012 07:36 PM, Ulrich Weigand wrote:
> Pedro Alves wrote:
>> On 01/16/2012 05:28 PM, Ulrich Weigand wrote:
>>> Maybe. On the other hand, once we've switched to the gdbarch based
>>> implementation, it would automatically work when not yet debugging
>>> a process anyway, so I'm not sure this is really necessary ...
>>
>> Hmm. I though the target_file_xxx routines would all fail, hitting the default
>> when no target implement the methods that way. IOW, I was thinking that we'd
>> need to pass the struct target_ops pointer down to the gdbarch callback so
>> the callback could work with the correct target.
>
> I'd really prefer the gdbarch callback to stand alone; longer term I think
> we ought to get rid of target_info_proc completely and have it just always
> use the gdbarch callback.
Ah. Yes, agreed.
>
> However, you're right that the target_fileio_ routines fail. I've now fixed
> this by making those fall back to the native target if we're not yet connected
> to any actual target (>= process_stratum), just like it is already done for
> target_get_osdata ...
Great, thanks!
--
Pedro Alves
prev parent reply other threads:[~2012-01-17 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 18:14 Ulrich Weigand
2012-01-16 16:39 ` Pedro Alves
2012-01-16 18:27 ` Ulrich Weigand
2012-01-16 19:38 ` Pedro Alves
2012-01-17 19:41 ` Ulrich Weigand
2012-01-17 19:46 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F15CF0A.2030909@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox