From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Pedro Alves <palves@redhat.com>,
gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [RFC] Make static tracepoint with markers more OO
Date: Mon, 16 Jan 2012 12:32:00 -0000 [thread overview]
Message-ID: <4F1418B2.5070308@redhat.com> (raw)
In-Reply-To: <m3y5tb8r7u.fsf@gmail.com>
On 01/13/2012 05:09 PM, Sergio Durigan Junior wrote:
>> > It's unfortunate to be calling the breakpoint's virtual methods
>> > before the object itself is created, which will require some redesign
>> > and refactoring if we ever switch to C++ (and is dangerous, as you may
>> > end up touching parts of the object which are not constructed yet by
>> > mistake), but, this is no worse than what we have now, so I'm fine with it.
> Yes, I understand what you're saying. I couldn't figure out a better
> way of handling this (except creating a "pre_breakpoint_ops"?).
Yeah, something like a factory object, along with trying to push out of
init_breakpoint_sal, etc. breakpoint-type specific bits, up into the callers, so
to get rid of layer inversion. Anyway, don't worry about it now. Your patch
is already a good cleanup.
> Anyway, thanks for the review, I will submit a fixed version of the patch in
> Tromey's reply.
--
Pedro Alves
next prev parent reply other threads:[~2012-01-16 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 7:24 Sergio Durigan Junior
2012-01-13 11:14 ` Pedro Alves
2012-01-13 17:24 ` Sergio Durigan Junior
2012-01-16 12:32 ` Pedro Alves [this message]
2012-01-13 15:46 ` Tom Tromey
2012-01-13 23:49 ` Sergio Durigan Junior
2012-01-16 17:03 ` Tom Tromey
2012-01-16 17:10 ` Sergio Durigan Junior
2012-01-16 17:19 ` Pedro Alves
2012-01-16 19:29 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1418B2.5070308@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox