From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7088 invoked by alias); 13 Jan 2012 17:24:07 -0000 Received: (qmail 7077 invoked by uid 22791); 13 Jan 2012 17:24:04 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jan 2012 17:23:50 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0DHNht4009912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 13 Jan 2012 12:23:43 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0DHNgft026511; Fri, 13 Jan 2012 12:23:42 -0500 Message-ID: <4F10689D.1080701@redhat.com> Date: Fri, 13 Jan 2012 18:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Yao Qi CC: "Gustavo, Luis" , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC stub-side break conditions 3/5] GDB-side changes References: <4F05BA10.3090107@mentor.com> <4F0C1D39.7050709@mentor.com> <4F104328.8090908@codesourcery.com> In-Reply-To: <4F104328.8090908@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00488.txt.bz2 On 01/13/2012 02:43 PM, Yao Qi wrote: > On 01/10/2012 07:12 PM, Luis Machado wrote: >>> I think the patches should include some tests for the new feature. >> >> Yes. I still need to think about those. >> >> I'll probably add a few GDB-side tests for safety, but mostly >> target-side ones like the tracepoint tests. > > This patch is about adding evaluating breakpoints' conditions in target > side, so existing test cases for condition breakpoints should be > sufficient for testing. We only need to force gdb to evaluate condition > in target side somewhere in test suite scripts. User can define > target_info in his/her board file to set where to evaluate condition, > host or target. You can just run the testsuite with GDBFLAGS set to "-ex \"set condition-evaluation target\"". > If we add new test cases, they should be used for both cases (condition > evaluated on host side vs. target side).