From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17744 invoked by alias); 13 Jan 2012 14:44:55 -0000 Received: (qmail 17732 invoked by uid 22791); 13 Jan 2012 14:44:54 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jan 2012 14:44:40 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1RliMx-0004vr-Ir from Yao_Qi@mentor.com ; Fri, 13 Jan 2012 06:44:39 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 13 Jan 2012 06:44:38 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Fri, 13 Jan 2012 06:44:38 -0800 Message-ID: <4F104328.8090908@codesourcery.com> Date: Fri, 13 Jan 2012 15:36:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111220 Thunderbird/9.0 MIME-Version: 1.0 To: "Gustavo, Luis" CC: Tom Tromey , Subject: Re: [RFC stub-side break conditions 3/5] GDB-side changes References: <4F05BA10.3090107@mentor.com> <4F0C1D39.7050709@mentor.com> In-Reply-To: <4F0C1D39.7050709@mentor.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00481.txt.bz2 On 01/10/2012 07:12 PM, Luis Machado wrote: >> I think the patches should include some tests for the new feature. > > Yes. I still need to think about those. > > I'll probably add a few GDB-side tests for safety, but mostly > target-side ones like the tracepoint tests. This patch is about adding evaluating breakpoints' conditions in target side, so existing test cases for condition breakpoints should be sufficient for testing. We only need to force gdb to evaluate condition in target side somewhere in test suite scripts. User can define target_info in his/her board file to set where to evaluate condition, host or target. If we add new test cases, they should be used for both cases (condition evaluated on host side vs. target side). -- Yao (齐尧)