From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15510 invoked by alias); 10 Jan 2012 20:26:39 -0000 Received: (qmail 15495 invoked by uid 22791); 10 Jan 2012 20:26:37 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jan 2012 20:26:19 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0AKPriB008138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jan 2012 15:25:53 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0AKPpcf005531; Tue, 10 Jan 2012 15:25:52 -0500 Message-ID: <4F0C9ECF.9000502@redhat.com> Date: Tue, 10 Jan 2012 20:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Tom Tromey CC: Pedro Alves , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.ada/catch_ex.exp, gdb.ada/mi_catch_ex.exp and unsupported catchpoints References: <201112061718.50031.pedro@codesourcery.com> <201112091800.02236.pedro@codesourcery.com> <201112101926.40691.pedro@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00309.txt.bz2 On 12/20/2011 02:51 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Here's a start. I didn't really try to confirm if I was extracting the > Pedro> arguments correctly for any other function bug the Ada runtime's > Pedro> function in question, but at least it works in the case we're > Pedro> interested in. :-) > > I think it looks pretty good. > > If you put this in, I will look at making the next-over-throw code use > it. That sounds nice. Joel wasn't very keen on it, so I'm not sure about the Ada parts. I've now put it at: https://github.com/palves/gdb/tree/build_prototype > Pedro> + /* The FULL_NAME pointer is at offset 8 of the object pointed by > Pedro> + E. */ > Pedro> + full_name_val = value_at (void_ptr_type, e + 8); > > 8 seems wrong on 32 bit. It looked okay to me, as the two preceding members are 4 bytes each, on both 32-bit and 64-bit, but ICBW. > Now, of course, we need struct layout code... :-) In any case, that'd be nice. :-) -- Pedro Alves