From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9176 invoked by alias); 9 Jan 2012 07:53:31 -0000 Received: (qmail 9166 invoked by uid 22791); 9 Jan 2012 07:53:29 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Jan 2012 07:53:16 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1RkA2c-0001HO-RJ from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Sun, 08 Jan 2012 23:53:14 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 8 Jan 2012 23:53:01 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Sun, 8 Jan 2012 23:53:12 -0800 Message-ID: <4F0A9CF0.2040408@codesourcery.com> Date: Mon, 09 Jan 2012 07:53:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111220 Thunderbird/9.0 MIME-Version: 1.0 To: Subject: Re: [RFA] Add test for use of "::" syntax for locals in watch. References: <20120109072642.2252F92BF6@kwai.gnat.com> In-Reply-To: <20120109072642.2252F92BF6@kwai.gnat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00265.txt.bz2 On 01/09/2012 03:26 PM, Paul Hilfinger wrote: > 2012-01-07 Paul Hilfinger > Your mail address is not correct :) I am not familiar with this test, but have some comments on format of changelog. > * gdb/testsuite/gdb.base/watchpoint.c (recurser): Initialize local_x. > (main) Repeat recurser call. ^^ Miss ":" here. > * gdb/testsuite/gdb.base/watchpoint.exp: Check that 'watch recurser::local_x' is > equivalent to 'local_x'. Each changelog entry is started from a tab. Since we have a ChangeLog file under gdb/testsuite, so we don't have to include "gdb/testuite" in file name. It can be like this, * gdb.base/watchpoint.c (recurser): Initialize local_x. (main): Repeat recurser call. * gdb.base/watchpoint.exp: Check that 'watch recurser::local_x' is equivalent to 'local_x'. -- Yao (齐尧)